fix(debugger): keep the selected tab when a step finishes

Every pause brought Threads & Variables to the front, so stepping from the
Console tab switched away from the output after each Step Over. Only a stop
at a breakpoint, exception or pause request does that now; finishing a step
keeps the tab the user is on.

Refs #2494

src-tauri/Cargo.toml

@@ -107,7 +107,6 @@ windows = { version = "0.62", features = [
 windows-sys = { version = "0.61", features = [
     "Win32_Foundation",
     "Win32_Graphics_Gdi",
-    "Win32_System_Diagnostics_Debug",
     "Win32_UI_Shell",
     "Win32_UI_WindowsAndMessaging",
 ] }

src-tauri/src/lib.rs

@@ -71,8 +71,6 @@ pub fn export_bindings(builder: &tauri_specta::Builder<tauri::Wry>) {
 #[cfg_attr(mobile, tauri::mobile_entry_point)]
 pub fn run() {
     ide_workspace::process::mark_start();
-    #[cfg(windows)]
-    quiet_error_dialogs();
     let context = tauri::generate_context!();
     #[cfg(debug_assertions)]
     let context = dev::configure(context);
@@ -391,16 +389,3 @@ pub(crate) fn dispatch_menu_action(app: &tauri::AppHandle, id: &str) {
         },
     }
 }
-
-/// Windows shows a modal "System Error" box when a process can't load a DLL (a broken
-/// `python.exe` found while detecting interpreters: "VCRUNTIME140.dll was not found").
-/// Child processes inherit the error mode, so probes and tools started by the IDE fail
-/// with an exit code instead (#1161).
-#[cfg(windows)]
-fn quiet_error_dialogs() {
-    use windows_sys::Win32::System::Diagnostics::Debug::{
-        SEM_FAILCRITICALERRORS, SEM_NOOPENFILEERRORBOX, SetErrorMode,
-    };
-    // SAFETY: SetErrorMode only changes this process's error mode flags.
-    unsafe { SetErrorMode(SEM_FAILCRITICALERRORS | SEM_NOOPENFILEERRORBOX) };
-}

src/features/debugger/__tests__/toolWindow.test.tsx

@@ -134,6 +134,11 @@ describe("debug tool window", () => {
     expect(console.getAttribute("aria-selected")).toBe("true");
     act(() => useDebug.setState({ sessions: { 1: session } }));
     expect(variables.getAttribute("aria-selected")).toBe("true");
+    // Stepping from the Console keeps it in front.
+    fireEvent.click(console);
+    act(() => useDebug.setState({ sessions: { 1: { ...session, status: "running" } } }));
+    act(() => useDebug.setState({ sessions: { 1: { ...session, stopReason: "step" } } }));
+    expect(console.getAttribute("aria-selected")).toBe("true");
   });
 
   it("renders session tabs, views, frames and typed variables", async () => {

src/features/debugger/ui/DebugToolWindow.tsx

@@ -153,7 +153,14 @@ export function DebugToolWindow() {
     setView({
       session: active.startedAt,
       status: active.status,
-      tab: active.status === "starting" ? "console" : active.status === "paused" ? "variables" : view.tab,
+      // A breakpoint or exception brings Threads & Variables to the front; finishing a step keeps
+      // the tab the user is on (e.g. Console, to watch the output while stepping).
+      tab:
+        active.status === "starting"
+          ? "console"
+          : active.status === "paused" && active.stopReason !== "step"
+            ? "variables"
+            : view.tab,
     });
   const tab = view.tab;