Files
openidea/src-tauri/src/titlebar.rs
T
l0ng-ai 9d030cd0a2 fix(window): stop macOS traffic lights jittering on resize
AppKit puts the title bar container and window buttons back at their defaults on every
live resize step, title change and fullscreen exit. Correcting them from window notifications
ran after that layout had been drawn, so the buttons bounced between the two positions, and
stayed at the defaults when no notification followed.

Correct the frames in a main run loop observer that runs after AppKit's layout and before
the Core Animation commit. Create project windows hidden so the buttons are placed before the
first frame, and skip repeated height updates from the toolbar.
2026-11-01 11:40:07 +08:00

107 lines
4.5 KiB
Rust

//! Keep the native window buttons aligned with the web toolbar, in AppKit points.
use std::cell::{Cell, RefCell};
use std::collections::HashMap;
use std::rc::Rc;
use block2::RcBlock;
use objc2_app_kit::{NSWindow, NSWindowButton, NSWindowStyleMask};
use objc2_core_foundation::{
CFIndex, CFOptionFlags, CFRetained, CFRunLoop, CFRunLoopActivity, CFRunLoopObserver, kCFRunLoopCommonModes,
};
use objc2_foundation::NSPoint;
/// AppKit lays out the title bar in a run loop observer and puts the buttons back at their
/// defaults on resize, title changes and fullscreen exit. Core Animation commits at 2000000, so
/// correcting the frames just before it keeps AppKit's positions off screen.
const BEFORE_COMMIT: CFIndex = 1_999_999;
struct Titlebar {
height: Rc<Cell<f64>>,
spacing: f64,
observer: CFRetained<CFRunLoopObserver>,
}
impl Drop for Titlebar {
fn drop(&mut self) {
self.observer.invalidate();
}
}
thread_local! {
static TITLEBARS: RefCell<HashMap<String, Titlebar>> = RefCell::default();
}
pub fn set_height(window: &tauri::WebviewWindow, height: f64) -> tauri::Result<()> {
let label = window.label().to_owned();
// with_webview runs on the AppKit thread; the observer is also delivered there.
window.with_webview(move |webview| unsafe {
let native = &*webview.ns_window().cast::<NSWindow>();
let Some(close) = native.standardWindowButton(NSWindowButton::CloseButton) else { return };
let Some(minimize) = native.standardWindowButton(NSWindowButton::MiniaturizeButton) else { return };
let Some(run_loop) = CFRunLoop::main() else { return };
let spacing = minimize.frame().origin.x - close.frame().origin.x;
TITLEBARS.with_borrow_mut(|bars| {
if let Some(bar) = bars.get(&label) {
bar.height.set(height);
center_buttons(native, height, bar.spacing);
return;
}
let shared = Rc::new(Cell::new(height));
let current = shared.clone();
let pointer = native as *const NSWindow;
let block = RcBlock::new(move |_: *mut CFRunLoopObserver, _: CFRunLoopActivity| {
center_buttons(&*pointer, current.get(), spacing)
});
let activities = CFRunLoopActivity::BeforeWaiting.0 as CFOptionFlags;
let Some(observer) = CFRunLoopObserver::with_handler(None, activities, true, BEFORE_COMMIT, Some(&block))
else {
return;
};
run_loop.add_observer(Some(&observer), kCFRunLoopCommonModes);
center_buttons(native, height, spacing);
bars.insert(label, Titlebar { height: shared, spacing, observer });
});
})
}
pub fn forget(window: &tauri::Window) {
let label = window.label().to_owned();
let _ = window.run_on_main_thread(move || {
TITLEBARS.with_borrow_mut(|bars| bars.remove(&label));
});
}
unsafe fn center_buttons(window: &NSWindow, height: f64, spacing: f64) {
// Fullscreen uses AppKit's own revealable title bar.
if window.styleMask().contains(NSWindowStyleMask::FullScreen) {
return;
}
let Some(close) = window.standardWindowButton(NSWindowButton::CloseButton) else { return };
let Some(container) = (unsafe { close.superview().and_then(|view| view.superview()) }) else { return };
let Some(content) = window.contentView() else { return };
let mut frame = container.frame();
let top = frame.origin.y + frame.size.height;
if (frame.size.height - height).abs() > 0.01 {
frame.size.height = height;
frame.origin.y = top - height;
container.setFrame(frame);
}
let bounds = content.bounds();
let y = bounds.origin.y + if content.isFlipped() { height / 2.0 } else { bounds.size.height - height / 2.0 };
for (index, kind) in [NSWindowButton::CloseButton, NSWindowButton::MiniaturizeButton, NSWindowButton::ZoomButton]
.into_iter()
.enumerate()
{
let Some(button) = window.standardWindowButton(kind) else { continue };
let Some(parent) = (unsafe { button.superview() }) else { continue };
let center = parent.convertPoint_fromView(NSPoint::new(0.0, y), Some(&content));
let frame = button.frame();
let x = 14.0 + index as f64 * spacing;
let target = center.y - frame.size.height / 2.0;
if (frame.origin.x - x).abs() > 0.01 || (frame.origin.y - target).abs() > 0.01 {
button.setFrameOrigin(NSPoint::new(x, target));
}
}
}