дзеркало
https://github.com/l0ng-ai/openidea.git
синхронізовано 2026-11-08 19:02:17 +02:00
* feat(editor): Drag tabs and files between split panes
HTML5 drag and drop never reaches the webview while native file drop is
enabled, so tab, project-file and changelist drags did nothing. They now
run on pointer events:
- Drag an editor tab onto another pane, or onto a pane's edge to split it.
- Drag files from the Project view into an editor pane (center opens them
there, an edge opens them in a new split).
- Drag files between changelists in the Commit view.
- "Drag-and-drop with Alt pressed only" applies to tabs and stripe buttons.
* fix(lsp): Deliver server settings and start servers on a supported JDK
- workspace/configuration answers a server's own section (basedpyright)
from its settings block; basedpyright runs in "standard" mode and keeps
auto search paths on, so `src/` layouts resolve from `tests/`.
- jdtls: formatting follows the editor indent, calls complete without
guessed arguments, and JDK internals stay out of completion.
- `max-java` in a language server config picks an installed JDK no newer
than that (kotlin-language-server fails on JDK 25).
- Server initialization may take up to 5 minutes (first Gradle import).
- `lsp_resend_diagnostics` re-emits stored diagnostics after a reload.
- Spelling only checks declared names (not called methods like
`substring`) and accepts plurals of known software terms.
* feat(editor): Quick fixes, completion and navigation while typing
Quick fixes
- Errors get a red quick-fix bulb; Apply Quick Fix (⌥⇧↵) fixes the most
severe problem at the caret, and the error hover offers the fix directly.
- Code generated by a code action is re-indented to the file's style.
- Python: Implement abstract methods (⌃I or the bulb) from the bases.
- Duplicate code actions are listed once.
Completion
- Overloads sharing a name, and a name importable from several modules,
are no longer merged into one entry.
- Auto-import entries show the module they import from.
- Call snippets without a stop (`new ArrayList<>()`) leave the caret inside
the parentheses with parameter info, or past them when nothing takes
arguments; parameter info also opens after server call snippets.
- The selected item is resolved ahead of acceptance, so its auto-import
is applied (rust-analyzer).
Navigation and diagnostics
- Language server requests wait for pending edits, so Go to Declaration
right after typing answers for the current text; an empty answer right
after an edit is retried while the server catches up.
- Diagnostics come back after a window reload; error underlines stay
visible under typo / unused highlighting.
- Implementation gutter markers no longer refresh in a loop while the
server reports progress.
- A missing alternative server no longer shows as a server error.
* chore(lint): Skip agent worktrees under .claude
* fix(editor): Skip cancelled LSP requests and limit generated-code reformat
- Requests cancelled while waiting for pending edits are not sent.
- Code generated by an action is reformatted per changed hunk, so an added
import doesn't reformat the code between it and the generated lines.
- A long busy spell caused by a settle refresh re-runs it only once.
- Files dropped on a file row of another changelist move to that changelist.
- Python Implement methods: a nested class without bases ends the lookup,
class bodies continue through unindented string lines, and
`@abstractproperty` stubs become `@property`.
- Resend diagnostics goes through the host ops, and custom servers get
`max_java`.
* fix(editor): Rank the exact type first in Java constructor completion
jdtls appends the call or body to filterText (`String(${0})`); matching
on the label instead lets typing `String` rank `String` above
`StringBuilder` and the other types sharing its sort text.
* fix(editor): List identical completion items once
kotlin-language-server repeats a class once per classpath entry declaring
it, so `String()` and `String` were listed three times each.
* fix(editor): Keep the internal cancellation message out of the UI text catalog
157 рядки
5.3 KiB
TypeScript
157 рядки
5.3 KiB
TypeScript
/**
|
||
* Pointer-driven drag & drop between components. HTML5 drag and drop can't be
|
||
* used: with the window's native file drop enabled, the webview never sees
|
||
* dragover / drop for drags that start inside it. Sources start a drag with
|
||
* `startPointerDrag` (or drive a `DragSession` themselves); targets register
|
||
* an element with `registerDropTarget` and are told about drags over it.
|
||
*/
|
||
import styles from "./pointerDrag.module.css";
|
||
|
||
/** What is dragged: `type` is matched by targets (e.g. `application/x-openidea-editor-tab`). */
|
||
export interface DragData {
|
||
type: string;
|
||
payload: string;
|
||
}
|
||
|
||
/** Project files dragged from the Project view: `payload` is the paths joined by `\n`. */
|
||
export const FILES_DRAG = "application/x-openidea-files";
|
||
|
||
export interface DropTarget {
|
||
accepts(type: string): boolean;
|
||
/** The pointer moved over the target. */
|
||
over(data: DragData, x: number, y: number): void;
|
||
/** The pointer left the target, or the drag ended elsewhere / was cancelled. */
|
||
leave(): void;
|
||
drop(data: DragData, x: number, y: number): void;
|
||
}
|
||
|
||
const targets = new Map<Element, DropTarget>();
|
||
|
||
export function registerDropTarget(el: Element, target: DropTarget): () => void {
|
||
targets.set(el, target);
|
||
return () => {
|
||
if (targets.get(el) === target) targets.delete(el);
|
||
};
|
||
}
|
||
|
||
/** The innermost registered target under (x, y) accepting `type`. */
|
||
function targetAt(type: string, x: number, y: number): DropTarget | null {
|
||
for (let el = document.elementFromPoint(x, y); el; el = el.parentElement) {
|
||
const t = targets.get(el);
|
||
if (t?.accepts(type)) return t;
|
||
}
|
||
return null;
|
||
}
|
||
|
||
export interface DragSession {
|
||
/** Updates hover feedback; true when a target under (x, y) accepts the drag. */
|
||
move(x: number, y: number): boolean;
|
||
/** Drops on the target under (x, y); false when there is none. */
|
||
drop(x: number, y: number): boolean;
|
||
cancel(): void;
|
||
}
|
||
|
||
export function dragSession(data: DragData): DragSession {
|
||
let current: DropTarget | null = null;
|
||
const enter = (t: DropTarget | null) => {
|
||
if (t === current) return;
|
||
current?.leave();
|
||
current = t;
|
||
};
|
||
return {
|
||
move(x, y) {
|
||
enter(targetAt(data.type, x, y));
|
||
current?.over(data, x, y);
|
||
return !!current;
|
||
},
|
||
drop(x, y) {
|
||
const t = targetAt(data.type, x, y);
|
||
enter(null);
|
||
t?.drop(data, x, y);
|
||
return !!t;
|
||
},
|
||
cancel: () => enter(null),
|
||
};
|
||
}
|
||
|
||
/** Movement before a press becomes a drag, px. */
|
||
const DRAG_THRESHOLD = 4;
|
||
|
||
/** Settings › Appearance › "Drag-and-drop with Alt pressed only" for tabs and stripe buttons. */
|
||
let requiresAlt = () => false;
|
||
export function setDragRequiresAlt(fn: () => boolean) {
|
||
requiresAlt = fn;
|
||
}
|
||
export const dragRequiresAlt = () => requiresAlt();
|
||
|
||
/**
|
||
* Starts a drag from a primary-button press on `source` once the pointer moved
|
||
* past the threshold; a ghost copy of `source` follows the pointer. Escape
|
||
* cancels. `onEnd` gets whether the drag happened (to swallow the click).
|
||
*/
|
||
export function startPointerDrag(
|
||
e: { button: number; clientX: number; clientY: number; altKey: boolean },
|
||
source: HTMLElement,
|
||
data: DragData,
|
||
opts: { onStart?: () => void; onEnd?: (dragged: boolean) => void } = {},
|
||
) {
|
||
if (e.button !== 0 || (requiresAlt() && !e.altKey)) return;
|
||
const start = { x: e.clientX, y: e.clientY };
|
||
let ghost: HTMLElement | null = null;
|
||
const session = dragSession(data);
|
||
const onMove = (ev: PointerEvent) => {
|
||
if (!ghost) {
|
||
if (Math.hypot(ev.clientX - start.x, ev.clientY - start.y) < DRAG_THRESHOLD) return;
|
||
const r = source.getBoundingClientRect();
|
||
ghost = source.cloneNode(true) as HTMLElement;
|
||
ghost.removeAttribute("id");
|
||
ghost.querySelectorAll("[id]").forEach((n) => n.removeAttribute("id"));
|
||
ghost.classList.add(styles.ghost!);
|
||
ghost.setAttribute("aria-hidden", "true");
|
||
Object.assign(ghost.style, {
|
||
left: `${r.left}px`,
|
||
top: `${r.top}px`,
|
||
width: `${r.width}px`,
|
||
height: `${r.height}px`,
|
||
});
|
||
document.body.appendChild(ghost);
|
||
document.documentElement.classList.add(styles.dragging!);
|
||
opts.onStart?.();
|
||
}
|
||
ghost.style.transform = `translate(${ev.clientX - start.x}px, ${ev.clientY - start.y}px)`;
|
||
ghost.classList.toggle(styles.noTarget!, !session.move(ev.clientX, ev.clientY));
|
||
};
|
||
const onUp = (ev: PointerEvent) => {
|
||
const dragged = !!ghost;
|
||
cleanup();
|
||
if (dragged) session.drop(ev.clientX, ev.clientY);
|
||
opts.onEnd?.(dragged);
|
||
};
|
||
const onKey = (ev: KeyboardEvent) => {
|
||
if (ev.key !== "Escape" || !ghost) return;
|
||
ev.preventDefault();
|
||
ev.stopPropagation();
|
||
session.cancel();
|
||
cleanup();
|
||
opts.onEnd?.(true);
|
||
};
|
||
const cleanup = () => {
|
||
window.removeEventListener("pointermove", onMove);
|
||
window.removeEventListener("pointerup", onUp);
|
||
window.removeEventListener("pointercancel", onCancel);
|
||
window.removeEventListener("keydown", onKey, true);
|
||
ghost?.remove();
|
||
document.documentElement.classList.remove(styles.dragging!);
|
||
};
|
||
const onCancel = () => {
|
||
session.cancel();
|
||
const dragged = !!ghost;
|
||
cleanup();
|
||
opts.onEnd?.(dragged);
|
||
};
|
||
window.addEventListener("pointermove", onMove);
|
||
window.addEventListener("pointerup", onUp);
|
||
window.addEventListener("pointercancel", onCancel);
|
||
window.addEventListener("keydown", onKey, true);
|
||
}
|