mirror of
https://github.com/l0ng-ai/openidea.git
synced 2026-11-08 08:52:12 +00:00
arookieofcanda-rookie-of-C-language
e85ffa2ae8
Git no longer asks for the HTTPS user name and password on every fetch, pull and push. The password prompt offers "Remember for this host"; the credential is saved in the app's secret store (next to the saved SSH passwords, never in git's global configuration) only after the git command that used it succeeds, and a stored credential the server rejects is forgotten so the next command asks again. Settings › Version Control › Git lists saved credentials and forgets them. Each git child gets its own id, passed to the askpass helper, so concurrent commands never save or forget each other's credentials. ide-vcs reports command completion through an observer installed at start-up instead of depending on ide-ssh. Credentials are keyed by scheme, host and port, and only git's authentication errors (Authentication failed, HTTP 401/403 responses, invalid username or password) forget a stored credential. Fixes #272 Co-authored-by: a-rookie-of-C-language <[email protected]>
76 lines
3.2 KiB
TypeScript
76 lines
3.2 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { DEFAULT_SSH_CONFIG, type SshConfigValid } from "@/platform/remoteSettings";
|
|
import { answerAskpass, askpassAnswer, dropAskpass, enqueueAskpass, useAskpass } from "./askpass";
|
|
import { sessionItems } from "./session";
|
|
|
|
describe("askpass queue", () => {
|
|
beforeEach(() => useAskpass.setState({ queue: [] }));
|
|
|
|
it("queues prompts in arrival order, once each", () => {
|
|
enqueueAskpass({ id: 1, prompt: "Password:", kind: "secret", remember: false });
|
|
enqueueAskpass({ id: 2, prompt: "Continue connecting (yes/no)?", kind: "confirm", remember: false });
|
|
enqueueAskpass({ id: 1, prompt: "Password:", kind: "secret", remember: false });
|
|
expect(useAskpass.getState().queue.map((p) => p.id)).toEqual([1, 2]);
|
|
});
|
|
|
|
it("drops a prompt answered elsewhere", () => {
|
|
enqueueAskpass({ id: 1, prompt: "a", kind: "text", remember: false });
|
|
enqueueAskpass({ id: 2, prompt: "b", kind: "text", remember: false });
|
|
dropAskpass(1);
|
|
dropAskpass(9);
|
|
expect(useAskpass.getState().queue.map((p) => p.id)).toEqual([2]);
|
|
});
|
|
|
|
it("answers the backend and shows the next prompt", () => {
|
|
const send = vi.fn((_id: number, _answer: string | null, _remember: boolean) => Promise.resolve());
|
|
enqueueAskpass({ id: 1, prompt: "a", kind: "secret", remember: true });
|
|
enqueueAskpass({ id: 2, prompt: "b", kind: "secret", remember: false });
|
|
answerAskpass({ id: 1, prompt: "a", kind: "secret", remember: true }, "hunter2", true, send);
|
|
expect(send).toHaveBeenCalledWith(1, "hunter2", true);
|
|
expect(useAskpass.getState().queue.map((p) => p.id)).toEqual([2]);
|
|
});
|
|
|
|
it("maps choices to answers", () => {
|
|
expect(askpassAnswer("secret", { text: "pw" })).toBe("pw");
|
|
expect(askpassAnswer("text", { text: "" })).toBe("");
|
|
expect(askpassAnswer("confirm", { confirm: true })).toBe("yes");
|
|
expect(askpassAnswer("confirm", { confirm: false })).toBe("no");
|
|
expect(askpassAnswer("secret", null)).toBeNull();
|
|
expect(askpassAnswer("confirm", null)).toBeNull();
|
|
});
|
|
});
|
|
|
|
describe("Start SSH Session chooser", () => {
|
|
const config = (patch: Partial<SshConfigValid>): SshConfigValid => ({ ...DEFAULT_SSH_CONFIG, ...patch });
|
|
|
|
it("lists configurations, then a way to edit them", () => {
|
|
const start = vi.fn();
|
|
const configure = vi.fn();
|
|
const items = sessionItems(
|
|
[
|
|
config({ id: "a", name: "Dev box", host: "box", user: "dev", port: 2222 }),
|
|
config({ id: "b", host: "bastion" }),
|
|
config({ id: "c", name: "Empty" }),
|
|
],
|
|
start,
|
|
configure,
|
|
);
|
|
expect(items.map((i) => [i.label, i.detail])).toEqual([
|
|
["Dev box", "dev@box:2222"],
|
|
["bastion", undefined],
|
|
["Empty", undefined],
|
|
["Edit SSH Configurations…", undefined],
|
|
]);
|
|
expect(items[2]!.disabled).toBeTruthy();
|
|
void items[0]!.run();
|
|
expect(start).toHaveBeenCalledWith("a");
|
|
void items[3]!.run();
|
|
expect(configure).toHaveBeenCalled();
|
|
});
|
|
|
|
it("offers to add one when there are none", () => {
|
|
const items = sessionItems([], vi.fn(), vi.fn());
|
|
expect(items.map((i) => i.label)).toEqual(["No SSH configurations. Add one…"]);
|
|
});
|
|
});
|