mirror of
https://github.com/l0ng-ai/openidea.git
synced 2026-11-08 08:52:12 +00:00
JawandClaude Opus 5.5
d1acf9f9ac
Ref-name inputs only validated after the fact, so a space typed or pasted into a branch name showed "Branch name contains invalid characters" and disabled Create. Branch-name fields (New Branch, from a revision and in several repositories, Rename Branch, New Worktree, GitHub New Remote Branch) now clean the name while typing: forbidden characters are dropped and whitespace becomes '-', without stacking separators, keeping the caret in place. Shared via src/platform/gitRefName.ts and the useSanitizedField hook in src/ui. Closes #1553 Co-authored-by: jaw52 <[email protected]> Co-Authored-By: Claude Opus 5.5 <[email protected]>
51 lines
1.7 KiB
TypeScript
51 lines
1.7 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { cleanUpBranchNameOnTyping } from "./gitRefName";
|
|
|
|
describe("cleanUpBranchNameOnTyping", () => {
|
|
it.each([
|
|
// The reported case: a space typed or pasted between words.
|
|
["feature x", "feature-x"],
|
|
["fix login redirect", "fix-login-redirect"],
|
|
// Repeated spaces collapse to one separator.
|
|
["a b", "a-b"],
|
|
["feature ", "feature-"],
|
|
// Space pressed again after the substituted separator, and spaces around a typed one.
|
|
["feature- ", "feature-"],
|
|
["feature - x", "feature-x"],
|
|
["a-b", "a-b"],
|
|
["a--b", "a--b"],
|
|
// A leading space would form a leading `-`, which git rejects: dropped.
|
|
[" feature", "feature"],
|
|
[" ", ""],
|
|
// Tabs and other control characters count as whitespace too.
|
|
["a\tb", "a-b"],
|
|
["a\u007fb", "a-b"],
|
|
// Characters git forbids are dropped rather than substituted.
|
|
["a~b^c:d?e*f[g\\h", "abcdefgh"],
|
|
['say "hi"', "say-hi"],
|
|
["a@{b", "ab"],
|
|
["a..b", "a.b"],
|
|
["a//b", "a/b"],
|
|
["/a", "a"],
|
|
[".a", "a"],
|
|
["-a", "a"],
|
|
["a/.b", "a/b"],
|
|
["a./b", "a/b"],
|
|
// Already valid names are untouched, including Unicode.
|
|
["feature/login-v2", "feature/login-v2"],
|
|
["release/1.2.3", "release/1.2.3"],
|
|
["fix_bug", "fix_bug"],
|
|
["功能/登录", "功能/登录"],
|
|
["", ""],
|
|
])("%j → %j", (input, expected) => {
|
|
expect(cleanUpBranchNameOnTyping(input)).toBe(expected);
|
|
});
|
|
|
|
it("is idempotent, so a cleaned field is stable under re-typing", () => {
|
|
for (const s of ["a b", " a", "a .. b", "@{ x", "x/ /y", "- - a"]) {
|
|
const once = cleanUpBranchNameOnTyping(s);
|
|
expect(cleanUpBranchNameOnTyping(once)).toBe(once);
|
|
}
|
|
});
|
|
});
|