Files
openidea/src/features/run/RunView.tsx
T
misswellandmisswell 438ab158ad fix(run): keep Stop in effect until the process is really gone (#1763)
Stop flipped the session back to Run as soon as the direct child exited, but a shell, Maven or the debug adapter can exit while the application it started still holds its port, so the next Run failed with "port already in use". The console also went quiet on a debug Stop because the DAP session was disconnected before java-debug drained the program's output, and closing a window killed running programs with SIGKILL at once.

Run and Debug sessions now stay in a stopping state from the Stop press until the whole process group (or the debuggee's pid tree) is gone. As in IntelliJ IDEA, the first Stop only interrupts and waits, and a second Stop kills; the Stop button turns into Kill process meanwhile. A rerun or restart waits for the old process without a time limit, and the termination time limit setting now only bounds a configuration's stop command. Debug launches record the program pid from the adapter's process/processid event, signal its pid tree and keep the adapter attached until the program exits; closing a project also stops debug sessions under its root. Closing a window with running programs shows a Terminating panel with Kill process and closes once they are gone.

Co-authored-by: misswell <[email protected]>
2026-11-07 10:15:30 +08:00

351 lines
12 KiB
TypeScript
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
import { useMemo, useState } from "react";
import type { RunTargetValid } from "@/platform/remoteSettings";
import { useWorkflowSettings } from "@/platform/workflowSettings";
import { EmptyState, IconButton, SplitGroup, SplitHandle, SplitPanel, Tabs, type TabItem, T } from "@/ui";
import { executeAction } from "@/platform/actions";
import { formatBinding, hostBinding, shortcutLabel } from "@/platform/keymap";
import { ConsoleModel } from "./console";
import { ConsoleView } from "./ConsoleView";
import { TerminalConsole } from "./TerminalConsole";
import { runDirectory } from "./navigate";
import { remoteLabel } from "./remote";
import {
acceptsInput,
clearConsole,
closeSessionTab,
closeStdin,
debugSession,
failedTests,
rerunFailed,
rerunSession,
resizeTerminal,
runSelectedTests,
runtime,
sendStdin,
setPendingInput,
stopSession,
useRun,
writeTerminal,
type RunSession,
isLive,
} from "./store";
import { TestTreeView, formatDuration } from "./TestTreeView";
import { StackTracePanel, closeStackTrace, useStackTraces, type StackTraceTab } from "./stackTrace";
import { showApplicationUpdate, useApplicationUpdates } from "./applicationUpdate";
import { isUpdatable } from "./updatePolicies";
import { configIcon } from "./configs";
import styles from "./Run.module.css";
import { tx } from "@/platform/i18n";
function failed(s: RunSession): boolean {
return s.status === "failed" || (s.status === "finished" && s.exitCode !== 0 && !s.stopped);
}
/**
* Tab icon, IDEA's three states: the green execution arrow while the process is alive,
* the red error badge for a failed exit, and once the process ended the run
* configuration's own icon (Services keeps the same model, see services.tsx).
*/
export function sessionIcon(s: RunSession): string {
if (isLive(s)) return s.config.isTest ? "check" : "run";
if (failed(s)) return "error";
// Ended (exit or stop): the configuration's own icon — the green arrow stays "still running".
return configIcon(s.config);
}
export function SessionPanel({
session,
onRerun,
onDebug,
onStop,
}: {
session: RunSession;
onRerun?: (() => void) | null;
/** Override the Debug button (Services: rerun the attached debugger's launch); null disables it. */
onDebug?: (() => void) | null;
onStop?: () => void;
}) {
const updating = useApplicationUpdates((s) => s.ids.has(session.id));
const version = useRun((s) => s.versions[session.id] ?? 0);
const rt = runtime(session.id);
const [follow, setFollow] = useState(true);
// Settings › Console › Use soft wraps is the default; the toolbar toggle overrides it for this tab.
const defaultWrap = useWorkflowSettings((s) => s.console.softWrap);
const [wrapOverride, setWrapOverride] = useState<boolean | null>(null);
const softWrap = wrapOverride ?? defaultWrap;
const [selectedTest, setSelectedTest] = useState<string | null>(null);
const [findOpen, setFindOpen] = useState(false);
const running = isLive(session);
const cwd = runDirectory(session.config.cwd);
// Selecting a test with captured output shows just that output (like IDEA).
const testModel = useMemo(() => {
const node = selectedTest ? rt?.tests?.get(selectedTest) : undefined;
if (!node || node.output.length === 0) return null;
const m = new ConsoleModel();
m.append({ kind: "stdout", text: node.output.join("\n") + "\n" });
return m;
}, [selectedTest, rt, version]); // eslint-disable-line react-hooks/exhaustive-deps
if (!rt) return null;
const toggleWrap = () => setWrapOverride(!softWrap);
const consoleColumn = (
<div className={styles.consoleColumn}>
{rt.console.dropped > 0 && !testModel && (
<div className={styles.notice}>{tx`${rt.console.dropped.toLocaleString()} earlier lines were discarded`}</div>
)}
{testModel && (
<div className={styles.notice}>
<button type="button" className={styles.noticeLink} onClick={() => setSelectedTest(null)}>
<T>Show all output</T>
</button>
</div>
)}
{rt.terminal && !testModel ? (
<TerminalConsole
output={rt.terminal}
cwd={cwd}
onData={(data) => writeTerminal(session.id, data)}
onResize={(cols, rows) => resizeTerminal(session.id, cols, rows)}
aria-label={tx`${session.config.name} terminal`}
/>
) : (
<ConsoleView
model={testModel ?? rt.console}
version={version}
softWrap={softWrap}
follow={testModel ? false : follow}
onFollowChange={setFollow}
findOpen={findOpen}
onFindOpenChange={setFindOpen}
cwd={cwd}
onClear={() => clearConsole(session.id)}
input={
!testModel && acceptsInput(session)
? {
pending: rt.input,
onChange: (text) => setPendingInput(session.id, text),
onSubmit: (line) => void sendStdin(session.id, line),
onEof: () => void closeStdin(session.id),
}
: undefined
}
aria-label={tx`${session.config.name} output`}
/>
)}
</div>
);
return (
<div className={styles.session}>
<div className={styles.toolbar} role="toolbar" aria-orientation="vertical" aria-label={tx("Run actions")}>
<IconButton
icon="rerun"
iconSize={14}
title="Rerun"
shortcut={shortcutLabel("run.rerun")}
disabled={onRerun === null}
onClick={onRerun ?? (() => rerunSession(session.id))}
/>
{/* Switch the launch mode: the same configuration started under the debugger. */}
<IconButton
icon="debug"
iconSize={14}
title="Debug"
shortcut={shortcutLabel("run.debug")}
disabled={onDebug === null}
onClick={onDebug ?? (() => void debugSession(session.id))}
/>
{rt.tests && (
<IconButton
icon="rerun"
iconSize={14}
tone="danger"
title="Rerun Failed Tests"
shortcut={shortcutLabel("run.rerunFailed")}
disabled={running || failedTests(session.id).length === 0}
onClick={() => rerunFailed(session.id)}
/>
)}
<IconButton
icon="stop"
iconSize={13}
title={session.status === "stopping" ? tx`Stopping… (click to kill)` : "Stop"}
tone={running || onStop ? "danger" : "default"}
disabled={!running && !onStop}
onClick={onStop ?? (() => void stopSession(session.id))}
/>
{isUpdatable(session.config) && (
<IconButton
icon="refresh"
title="Update Application"
shortcut={shortcutLabel("run.updateApplication")}
disabled={session.status !== "running" || updating}
onClick={() => showApplicationUpdate(session.id)}
/>
)}
<div className={styles.toolbarSep} />
{!rt.terminal && (
<>
<IconButton
icon="search"
iconSize={14}
title="Find…"
shortcut={formatBinding(hostBinding("Meta+F"))}
pressed={findOpen}
onClick={() => setFindOpen((v) => !v)}
/>
<IconButton
icon="arrow-down"
iconSize={14}
title="Scroll to End"
pressed={follow}
onClick={() => setFollow((v) => !v)}
/>
<IconButton icon="soft-wrap" iconSize={14} title="Soft-Wrap" pressed={softWrap} onClick={toggleWrap} />
</>
)}
<IconButton icon="trash" iconSize={14} title="Clear All" onClick={() => clearConsole(session.id)} />
<div className={styles.toolbarSep} />
<IconButton
icon="settings"
iconSize={14}
title="Edit Configurations…"
onClick={() => void executeAction("run.editConfigs", session.config.id)}
/>
</div>
<div className={styles.sessionBody}>
{rt.tests ? (
<SplitGroup orientation="horizontal" id={`run-tests-${session.id}`} className={styles.testSplit}>
<SplitPanel id="tests" defaultSize="32%" minSize="140px">
<TestTreeView
results={rt.tests}
version={version}
cwd={cwd}
running={running}
selected={selectedTest}
onSelect={setSelectedTest}
onRunTests={(ids, debug) => void runSelectedTests(session.id, ids, debug)}
/>
</SplitPanel>
<SplitHandle />
<SplitPanel id="console" minSize="200px">
{consoleColumn}
</SplitPanel>
</SplitGroup>
) : (
consoleColumn
)}
</div>
</div>
);
}
function sessionItems(sessions: readonly RunSession[], targets: readonly RunTargetValid[]): TabItem[] {
return sessions.map((s) => ({
id: s.id,
label: remoteLabel(s.config, targets),
text: remoteLabel(s.config, targets),
icon: sessionIcon(s),
color: failed(s) ? "var(--danger)" : undefined,
closable: true,
tooltip:
s.status === "finished"
? tx`Finished in ${formatDuration((s.endedAt ?? s.startedAt) - s.startedAt)}, exit code ${s.exitCode ?? "?"}`
: undefined,
}));
}
/** The selected tab: a run session or an analyzed stack trace (IDEA shows both in Run). */
function currentTab(
sessions: readonly RunSession[],
traces: readonly StackTraceTab[],
active: string | null,
): { session: RunSession } | { trace: StackTraceTab } | null {
const session = sessions.find((s) => s.id === active);
if (session) return { session };
const trace = traces.find((t) => t.id === active);
if (trace) return { trace };
if (sessions.length) return { session: sessions[sessions.length - 1]! };
return traces.length ? { trace: traces[traces.length - 1]! } : null;
}
/** Session (and stack trace) tabs in the tool window header. */
export function RunTabs() {
const sessions = useRun((s) => s.sessions);
const traces = useStackTraces((s) => s.tabs);
const runTargets = useWorkflowSettings((s) => s.runTargets);
const active = useRun((s) => s.activeSession);
const current = currentTab(sessions, traces, active);
if (!current) return null;
const items: TabItem[] = [
...sessionItems(sessions, runTargets),
...traces.map((t) => ({ id: t.id, label: t.title, text: t.title, closable: true })),
];
return (
<Tabs
variant="compact"
className={styles.tabs}
aria-label="Run sessions"
items={items}
activeId={"session" in current ? current.session.id : current.trace.id}
onSelect={(id) => useRun.setState({ activeSession: id })}
onClose={(id) => (traces.some((t) => t.id === id) ? closeStackTrace(id) : void closeSessionTab(id))}
panelIdPrefix="openidea-run"
/>
);
}
export function RunView() {
const sessions = useRun((s) => s.sessions);
const traces = useStackTraces((s) => s.tabs);
const active = useRun((s) => s.activeSession);
const current = currentTab(sessions, traces, active);
if (!current) {
// IDEA's empty Run tool window: the three ways to run something.
const chooser = shortcutLabel("run.chooseConfig");
return (
<EmptyState>
<div className={styles.emptyHints}>
<T>To run your code, do one of the following:</T>
<ul>
<li>
<T>Click the Run icon in the editor gutter</T>
</li>
<li>
<T>{'Select "Run…" in the editor context menu'}</T>
</li>
<li>
<T>Launch a</T>{" "}
<button type="button" className={styles.noticeLink} onClick={() => void executeAction("run.editConfigs")}>
<T>run configuration</T>
</button>
{chooser && <span className={styles.chooserMuted}> ({chooser})</span>}
</li>
</ul>
</div>
</EmptyState>
);
}
const id = "session" in current ? current.session.id : current.trace.id;
return (
<div className={styles.root}>
<div
className={styles.panel}
role="tabpanel"
id={`openidea-run-panel-${id}`}
aria-labelledby={`openidea-run-tab-${id}`}
>
{"session" in current ? (
<SessionPanel key={id} session={current.session} />
) : (
<StackTracePanel key={id} tab={current.trace} />
)}
</div>
</div>
);
}