fix(app): keep update progress visible on the welcome screen (#951)

Check for Updates on the welcome screen showed nothing while the request was out: the check ran only as a status-bar task, and the welcome screen has no status bar. Leaving a project also dropped every notification, including a running update download.

A check started with no project or LightEdit window open now shows its progress in a balloon (keyed like the result, so the result replaces it); project windows keep it in the status bar. A project switch clears only project notifications and keeps the app-wide update ones.

Co-authored-by: youngtseup <[email protected]>

src/workbench/activate.ts

@@ -15,7 +15,7 @@ import { installBrowserGuards } from "./browserGuards";
 import { installDistractionFree } from "./distractionFree";
 import { installFileDrop } from "./fileDrop";
 import { installFocusTracking } from "./focus";
-import { clearNotifications, installNotifyEvents, notificationServiceImpl } from "./notificationStore";
+import { clearProjectNotifications, installNotifyEvents, notificationServiceImpl } from "./notificationStore";
 import {
   NOTIFICATIONS_TOOL_WINDOW,
   NotificationsHeaderActions,
@@ -51,7 +51,7 @@ export function activateWorkbench(): () => void {
   const unsubProject = useProject.subscribe((s, prev) => {
     if (s.project?.root === prev.project?.root && s.lightEdit === prev.lightEdit) return;
     // The previous project's notifications (and their actions) no longer apply.
-    if (prev.project) clearNotifications();
+    if (prev.project) clearProjectNotifications();
     onProject(s.project?.root ?? null);
   });
 

src/workbench/notificationStore.ts

@@ -175,6 +175,11 @@ export function clearNotifications() {
   useNotifications.setState({ items: [] });
 }
 
+/** A project switch drops the previous project's notifications; app-wide ones (updates) stay. */
+export function clearProjectNotifications() {
+  useNotifications.setState((s) => ({ items: s.items.filter((x) => x.group === "updates") }));
+}
+
 /** The list was seen: everything is read and no longer shown as a balloon. */
 export function markAllNotificationsRead() {
   useNotifications.setState((s) => ({

src/workbench/projectNotifications.test.ts

@@ -0,0 +1,26 @@
+import { afterEach, describe, expect, it } from "vitest";
+import { useProject } from "@/platform/project";
+import { activateWorkbench } from "./activate";
+import { notify, useNotifications } from "./notificationStore";
+
+afterEach(() => {
+  useNotifications.setState({ items: [] });
+  useProject.setState({ project: null, lightEdit: false });
+});
+
+describe("notifications across project changes", () => {
+  it("keeps app-level update notifications and drops project ones", () => {
+    useProject.setState({
+      project: { root: "/p", name: "p", trusted: true, isGit: false, settings: {} } as never,
+    });
+    const dispose = activateWorkbench();
+    try {
+      notify({ level: "info", title: "Downloading OpenIDEA 0.1.35", key: "app.update", sticky: true });
+      notify({ level: "info", title: "Git refresh failed", group: "vcs" });
+      useProject.setState({ project: null });
+      expect(useNotifications.getState().items.map((n) => n.title)).toEqual(["Downloading OpenIDEA 0.1.35"]);
+    } finally {
+      dispose();
+    }
+  });
+});