From 42968a39b35504e401bba1010e2a4b65f859db5c Mon Sep 17 00:00:00 2001
From: l0ng-ai <24760907+l0ng-ai@users.noreply.github.com>
Date: Wed, 4 Nov 2026 09:37:58 +0800
Subject: [PATCH] style(ui): remove hover backgrounds from icon actions

---
 src/features/database/Database.module.css            | 3 ---
 src/features/github/reviewMode/ReviewMode.module.css | 3 ++-
 src/features/http-client/HttpClient.module.css       | 3 ---
 src/features/run/Run.module.css                      | 3 ---
 src/features/vcs/DiffEditor.module.css               | 4 ++--
 src/ui/Button.module.css                             | 3 +--
 src/workbench/TitleBar.module.css                    | 6 +-----
 src/workbench/toolwindows/ToolWindows.module.css     | 4 +++-
 8 files changed, 9 insertions(+), 20 deletions(-)

diff --git a/src/features/database/Database.module.css b/src/features/database/Database.module.css
index 7f47f5591..d620be9ea 100644
--- a/src/features/database/Database.module.css
+++ b/src/features/database/Database.module.css
@@ -627,9 +627,6 @@
   color: var(--fg-secondary);
   cursor: pointer;
 }
-:global(.cm-openidea-db-banner-close:hover) {
-  background: var(--bg-hover);
-}
 
 /* Parameter info in `VALUES (…)`. */
 :global(.cm-openidea-db-params) {
diff --git a/src/features/github/reviewMode/ReviewMode.module.css b/src/features/github/reviewMode/ReviewMode.module.css
index d2f459e2d..41c840a6e 100644
--- a/src/features/github/reviewMode/ReviewMode.module.css
+++ b/src/features/github/reviewMode/ReviewMode.module.css
@@ -33,7 +33,8 @@
   font-size: var(--fs-small, var(--fs-ui));
 }
 
-.button:hover {
+.button.text:hover,
+.button[aria-expanded="true"] {
   background-color: var(--bg-toolbar-hover);
 }
 
diff --git a/src/features/http-client/HttpClient.module.css b/src/features/http-client/HttpClient.module.css
index 1f57b58de..2c32796ce 100644
--- a/src/features/http-client/HttpClient.module.css
+++ b/src/features/http-client/HttpClient.module.css
@@ -16,9 +16,6 @@
   border-radius: var(--radius-small);
   cursor: pointer;
 }
-.runMarker:hover {
-  background: var(--bg-hover);
-}
 
 /* Toolbar panel above `.http` files. */
 .toolbar {
diff --git a/src/features/run/Run.module.css b/src/features/run/Run.module.css
index d1b049f48..677ba9c6b 100644
--- a/src/features/run/Run.module.css
+++ b/src/features/run/Run.module.css
@@ -727,9 +727,6 @@
   border-radius: var(--radius-small);
   cursor: pointer;
 }
-.runMarker:hover {
-  background: var(--bg-hover);
-}
 
 /* Run dialogs (rerun confirmation, $Prompt$). */
 .dialogBody {
diff --git a/src/features/vcs/DiffEditor.module.css b/src/features/vcs/DiffEditor.module.css
index 5fc7db47a..faa9d9de7 100644
--- a/src/features/vcs/DiffEditor.module.css
+++ b/src/features/vcs/DiffEditor.module.css
@@ -151,7 +151,7 @@
 }
 .host :global(.cm-merge-revert button:hover) {
   color: var(--fg-strong);
-  background: var(--bg-hover);
+  background: transparent;
 }
 .select {
   height: var(--h-control-small);
@@ -277,7 +277,7 @@
 }
 .host :global(.cm-diffDivider button.cm-diffArrow:hover) {
   color: var(--fg-strong);
-  background: var(--bg-hover);
+  background: transparent;
 }
 /* Where the other pane has lines this one lacks. */
 .host :global(.cm-diffGap-inserted) {
diff --git a/src/ui/Button.module.css b/src/ui/Button.module.css
index ec810632d..9d5797cec 100644
--- a/src/ui/Button.module.css
+++ b/src/ui/Button.module.css
@@ -71,7 +71,7 @@
   color: var(--fg-faint);
 }
 
-/* Toolbar / action buttons (ActionButton): transparent, rounded-square hover. */
+/* Toolbar / action buttons: transparent on hover, filled when pressed or selected. */
 .iconButton {
   flex: none;
   display: inline-flex;
@@ -88,7 +88,6 @@
   outline-offset: -2px;
 }
 .iconButton:not(:disabled):hover {
-  background: var(--bg-toolbar-hover);
   color: var(--fg-strong);
 }
 .iconButton:not(:disabled):active {
diff --git a/src/workbench/TitleBar.module.css b/src/workbench/TitleBar.module.css
index db4c57ffd..a3b632de2 100644
--- a/src/workbench/TitleBar.module.css
+++ b/src/workbench/TitleBar.module.css
@@ -52,8 +52,7 @@
   gap: 6px;
 }
 .widget:hover,
-.widget[aria-expanded="true"],
-.tool:hover {
+.widget[aria-expanded="true"] {
   background: var(--bg-toolbar-hover);
 }
 .widgetText {
@@ -116,9 +115,6 @@
   background: transparent;
   color: var(--fg-secondary);
 }
-.mainMenuButton:hover {
-  background: var(--bg-toolbar-hover);
-}
 .mainMenuButton:focus-visible,
 .menuTitle:focus-visible,
 .caption:focus-visible {
diff --git a/src/workbench/toolwindows/ToolWindows.module.css b/src/workbench/toolwindows/ToolWindows.module.css
index 6523b567b..200448b91 100644
--- a/src/workbench/toolwindows/ToolWindows.module.css
+++ b/src/workbench/toolwindows/ToolWindows.module.css
@@ -264,9 +264,11 @@
 }
 .stripeButton:hover,
 .stripeButton[aria-expanded="true"] {
-  background: var(--bg-stripe-hover);
   color: var(--fg-secondary);
 }
+.stripeButton[aria-expanded="true"] {
+  background: var(--bg-stripe-hover);
+}
 .stripeActive,
 .stripeActive:hover {
   background: var(--bg-stripe-selected);